Update trec_eval Fix #475 #477
Conversation
Updated trec_eval to latest version. Running old version can result in a segmentation fault.
|
Hi @chriskamphuis I only see removal of the existing tarball? There isn't a new one? |
|
Hi @lintool, I replaced it with a tarball with the same name. The commit shows that the file is modified (not deleted). |
|
Ah, I see - misread. The new tarball is created from https://github.com/usnistgov/trec_eval/ ? |
Tarball is created from usnistgov/trec_eval with a5211566d0c9e2ec337bacf327b9350ab5b3edde as latest commit.
|
I included the commit id in the commit that changed the name, the commit id of usnistgov/trec_eval is a5211566d0c9e2ec337bacf327b9350ab5b3edde. |
|
@chriskamphuis sorry to be kinda a pain, but we're try to implement rigorous software engineering practices in this project - CI is failing because of this - https://github.com/castorini/Anserini/blob/master/.travis.yml#L16 File name needs to be updated. Can you please do so? |
|
@lintool Yes, no problem, I am working on it. I will also update the markdown files so it will be consistent. |
Renamed in all relevant files
| @@ -60,47 +60,47 @@ nohup target/appassembler/bin/SearchCollection -topicreader Webxml -index lucene | |||
| Evaluation can be performed using `trec_eval` and `gdeval.pl`: | |||
|
|
|||
| ``` | |||
| eval/trec_eval.9.0/trec_eval -m map -m P.30 src/main/resources/topics-and-qrels/qrels.web.51-100.txt run.cw09b.bm25.topics.web.51-100.txt | |||
There was a problem hiding this comment.
It is a bit odd why there is an extra empty line here.
Did you manually change this file?
There was a problem hiding this comment.
@Peilin-Yang are those parts auto-gen'ed? Perhaps @chriskamphuis doesn't know about the details of the regression framework...
There was a problem hiding this comment.
All experiments-{$collection}.md files are auto-generated.
@chriskamphuis Could you please run mvn test locally and see if there is any diff?
There was a problem hiding this comment.
@Peilin-Yang No diff for me locally. I only changed the the index.md and yaml files. Then I ran test before pushing the changes. Maybe I accidentally added an extra line when checking if everything was correct, but then it should be removed when running mvn test right?
|
@chriskamphuis thanks for your first contribution. Looking forward to many more in the future! |
Updated trec_eval to latest version. Running old version can result in a
segmentation fault.